Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Loading Pods View" and "failed to get pod details" state on UI #2248

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

adarsh0728
Copy link
Contributor

@adarsh0728 adarsh0728 commented Dec 2, 2024

Resolves #2089 and Resolves #2240

Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
@adarsh0728 adarsh0728 linked an issue Dec 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.26%. Comparing base (5f69064) to head (df1fff0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2248      +/-   ##
==========================================
+ Coverage   65.19%   65.26%   +0.06%     
==========================================
  Files         346      346              
  Lines       42062    42062              
==========================================
+ Hits        27423    27450      +27     
+ Misses      13566    13542      -24     
+ Partials     1073     1070       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
@adarsh0728
Copy link
Contributor Author

adarsh0728 commented Dec 3, 2024

Whenever new pods are up, we get the new pods' metadata from the main Kubernetes API immediately. But, the metrics API takes some time to render data for the new pods (continues showing data for older pod). We were waiting for these two API's response. Ideally, if we have the metadata (name, status etc) of pods, we should show that to the users instead of "Loading Pods View".

Also, whenever there was any error in metrics API or the main API , we were throwing error "Failed to get pods details". This was caused mainly because of metrics API, as soon as we set up a pipeline and call it due to the same reason as mentioned above.

@adarsh0728 adarsh0728 marked this pull request as ready for review December 4, 2024 09:04
@vigith vigith merged commit df9be77 into numaproj:main Dec 9, 2024
25 checks passed
@adarsh0728 adarsh0728 deleted the fix/pods-view branch December 10, 2024 08:53
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Jan 19, 2025
@veds-g veds-g mentioned this pull request Feb 3, 2025
20 tasks
veds-g pushed a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants