Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's time for refactoring #177

Closed
7 tasks done
numToStr opened this issue Jul 7, 2022 · 1 comment · Fixed by #179
Closed
7 tasks done

It's time for refactoring #177

numToStr opened this issue Jul 7, 2022 · 1 comment · Fixed by #179
Labels
enhancement New feature or request

Comments

@numToStr
Copy link
Owner

numToStr commented Jul 7, 2022 •
edited
Loading

It's the time of the year when we do refactoring

  • use string.gsub string.gsub is nice #176 (used wherever necessary)
  • make min_indent arg interger
  • make U.unwrap_cstr to return string instead of string|bool
  • make U.comment_str return closure | Renamed to U.commenter
  • make U.uncomment_str return closure (or return iterator)
  • merge Op.blockwise and Op.blockwise_x
  • make padding arg interger gain < effort

(I'll add more stuff if needed)
@numToStr numToStr added the enhancement New feature or request label Jul 7, 2022
@numToStr
Copy link
Owner Author

numToStr commented Jul 7, 2022 •
edited
Loading

This maybe a breaking change if you are depending on the internal functions. So I'll create a tagged release first.

@numToStr numToStr mentioned this issue Jul 12, 2022
Merged
numToStr added a commit that referenced this issue Jul 17, 2022
@numToStr
chore!: refactoring (#179)
761f63f 
### Added
- `utils.commenter()`
- `utils.uncommenter()`

### Changed
- `utils.{unwrap_cstr,parse_cstr}()` now returns `string, string` instead of `string|bool, string|bool`
- Merged `Op.blockwise_x()` with `Op.blockwise()`
- Removed `utils.get_padding()`, `utils.move_n_insert()` and `utils.grab_indent()`
- Removed `utils.comment_str()` (Use `utils.commenter()`)
- Removed `utils.uncomment_str()` (Use `utils.uncommenter()`)
- Changed `utils.is_commented()` function signature.

Resolve #177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore!: refactoring numToStr/Comment.nvim
1 participant
@numToStr