Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing more than 1000 last.fm tracks #1251

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Allow importing more than 1000 last.fm tracks #1251

merged 2 commits into from
Apr 11, 2022

Conversation

nukeop
Copy link
Owner

@nukeop nukeop commented Apr 11, 2022

Closes #881

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1251 (94144fe) into master (0eb6308) will increase coverage by 0.26%.
The diff coverage is 77.08%.

@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
+ Coverage   68.47%   68.74%   +0.26%     
==========================================
  Files         329      330       +1     
  Lines        6078     6123      +45     
  Branches      407      416       +9     
==========================================
+ Hits         4162     4209      +47     
+ Misses       1580     1575       -5     
- Partials      336      339       +3     
Impacted Files Coverage Δ
packages/core/src/persistence/store.js 58.06% <33.33%> (ø)
packages/app/app/actions/dashboard.ts 85.00% <50.00%> (+2.07%) ⬆️
packages/app/app/reducers/favorites.js 71.42% <66.66%> (ø)
packages/app/app/actions/importfavs.ts 73.52% <73.68%> (+51.30%) ⬆️
packages/app/app/actions/favorites.ts 98.18% <100.00%> (+0.30%) ⬆️
packages/app/test/mockElectronStore.ts 100.00% <100.00%> (ø)
packages/app/test/storeBuilders.ts 86.95% <100.00%> (ø)
packages/core/src/rest/Lastfm.ts 50.00% <100.00%> (+3.84%) ⬆️
packages/ui/lib/components/SearchBox/index.tsx 29.31% <0.00%> (-13.55%) ⬇️
packages/app/app/reducers/dashboard.ts 70.00% <0.00%> (-10.00%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb6308...94144fe. Read the comment docs.

@nukeop nukeop merged commit 44c82da into master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import Last.fm favorites gives "Error: Invalid number of favorites [2664]"
1 participant