Fix MPRIS for flatpak

[swick]

Untested because I can't be arsed to build this thing. The problem is that the MPRIS bus for an app should be org.mpris.MediaPlayer2.$APPID so in this case org.mpris.MediaPlayer2.org.js.nuclear.Nuclear but it is org.mpris.MediaPlayer2.Nuclear_Music_Player. Flatpak enforces the bus naming so it doesn't show up outside the sandbox.

As a workaround one can override the flatpak permissions so that nuclear can own the bus name org.mpris.MediaPlayer2.Nuclear_Music_Player on the session bus.

[nukeop]

Ok, but if it's untested, how do I know it will work?

[codecov]

Codecov Report

Merging #1032 (89210c2) into master (52e8851) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1032   +/-   ##
=======================================
  Coverage   60.78%   60.78%           
=======================================
  Files         273      273           
  Lines        4786     4786           
  Branches      306      306           
=======================================
  Hits         2909     2909           
  Misses       1617     1617           
  Partials      260      260           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e8851...89210c2. Read the comment docs.

[swick]

How am I supposed to test this?

The flatpak builder manifest builds only from releases on github and the docker npm install step fails with

> nuclear@0.6.16 postinstall
> lerna bootstrap --hoist --no-ci && electron-builder install-app-deps && electron-rebuild

lerna notice cli v3.22.1
lerna info Bootstrapping 5 packages
lerna info Installing external dependencies
lerna info hoist Installing hoisted dependencies into root
lerna info hoist Pruning hoisted dependencies
lerna info hoist Finished pruning hoisted dependencies
lerna ERR! npm install exited 1 in 'nuclear'
lerna ERR! npm install stderr:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: nuclear@0.6.16
npm ERR! Found: typescript@4.3.5
npm ERR! node_modules/typescript
npm ERR!   dev typescript@"^4.2.4" from the root project
npm ERR!   peer typescript@"*" from ts-loader@8.3.0
npm ERR!   node_modules/ts-loader
npm ERR!     ts-loader@"^8.0.3" from the root project
npm ERR!     peer ts-loader@"*" from @storybook/preset-typescript@2.1.0
npm ERR!     node_modules/@storybook/preset-typescript
npm ERR!       @storybook/preset-typescript@"^2.1.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@"^3.4" from @storybook/preset-typescript@2.1.0
npm ERR! node_modules/@storybook/preset-typescript
npm ERR!   @storybook/preset-typescript@"^2.1.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /root/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-08-04T11_41_49_798Z-debug.log

lerna ERR! npm install exited 1 in 'nuclear'
npm ERR! code 1
npm ERR! path /nuclear
npm ERR! command failed
npm ERR! command sh -c lerna bootstrap --hoist --no-ci && electron-builder install-app-deps && electron-rebuild

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-08-04T11_41_49_897Z-debug.log