Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandcamp Metadata, cannot read property length. #1026

Closed
lunar-d opened this issue Jul 23, 2021 · 1 comment · Fixed by #1028
Closed

Bandcamp Metadata, cannot read property length. #1026

lunar-d opened this issue Jul 23, 2021 · 1 comment · Fixed by #1028
Labels
bug This issue identifies a bug in Nuclear. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.

Comments

@lunar-d
Copy link

lunar-d commented Jul 23, 2021

Hi,
i use: Linux (Manjaro) AUR : nuclear-player-bin 0.6.16-2

It seems that the Bandcamp provider looks for the length of all the tracks of an album even those which are not yet released/available.
As no information is available for these tracks, the provider returns an error:

TypeError: Cannot read property 'length' of undefined
    at Object.t.stringDurationToSeconds (renderer.js:1)
    at renderer.js:1
    at Array.map (<anonymous>)
    at Object.t.useAlbumViewProps (renderer.js:1)
    at t.default (renderer.js:1)
    at Xr (1.renderer.js:2613)
    at vA (1.renderer.js:2613)
    at Io (1.renderer.js:2613)
    at Ms (1.renderer.js:2613)
    at os (1.renderer.js:2613)
    at $o (1.renderer.js:2613)
    at 1.renderer.js:2613
    at t.unstable_runWithPriority (1.renderer.js:2643)
    at _i (1.renderer.js:2613)
    at Ji (1.renderer.js:2613)
    at Gi (1.renderer.js:2613)
    at es (1.renderer.js:2613)
    at Object.notify (1.renderer.js:2621)
    at e.t.notifyNestedSubs (1.renderer.js:2621)
    at e.t.handleChangeWrapper (1.renderer.js:2621)
    at w (1.renderer.js:2629)
    at renderer.js:1

an example of a pre-order album: https://vyletpony.bandcamp.com/album/cutiemarks-and-the-things-that-bind-us

@lunar-d lunar-d added the bug This issue identifies a bug in Nuclear. label Jul 23, 2021
@nukeop nukeop added the good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. label Jul 23, 2021
@nukeop
Copy link
Owner

nukeop commented Jul 23, 2021

Hi, thanks for the report. I think you're right, this bug occurs here: https://github.com/nukeop/nuclear/blob/master/packages/app/app/utils.ts#L27

It should be a matter of using the .? accessor to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue identifies a bug in Nuclear. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants