chore: drop bun chdir hack #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobkd
force-pushed
the
chore/drop-bun-abs-dir-fix
branch
from
208e97d to
23ce0d5
Compare
|
Another awesome contribution. I'm glad you understand the codebase so well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I have seen, this works without the hack now.
This should also allow
buntests on Windows (See oven-sh/bun#11904 for chdir issue in tests)Test run: https://github.com/nobkd/nue/actions/runs/9532359784
EDIT: I should try running this with a real code base, and not just with the tests
Edit 2: As far as I can see, this works just fine