Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Again! Fix the failed CI (2) #215

Closed
wants to merge 5 commits into from
Closed

Again! Fix the failed CI (2) #215

wants to merge 5 commits into from

Conversation

fritx
Copy link
Collaborator

@fritx fritx commented Feb 22, 2024

✅ CI is now passing again:
https://github.com/fritx/nue/actions/runs/8000712843

  1. Attempt to pass the CI by handling missing pubDate while sorting
  2. Attempt to pass the Windows CI by adapting dir path
  3. Attempt to pass the (Node) CI by replacing import.meta.resolve
    • Tried import.meta.resolve iwth both Node@18.18 and Node@18.19.1 in CI but failed.
    • While running *.mjs with import.meta.resolve is fine with Node@18.19.1 locally. Any one knows why?
  4. Attempt to pass the Windows CI by removing the leading slash from absolute path
    • The logic appears in several places and can be extracted in the future, maybe next PR.
  5. Pass the CI by reverting the latest changes in glow.js

ref: #214

@fritx fritx mentioned this pull request Feb 22, 2024
Merged
@tipiirai
Copy link
Contributor

Awesome. Can you resolve the conflict?

@fritx
Copy link
Collaborator Author

fritx commented Feb 22, 2024

Closing in favor of #214

@fritx fritx closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritx @tipiirai