fix: add type to favicon field #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritx
reviewed
Jan 3, 2024
| @@ -53,7 +54,7 @@ export function renderHead(data, is_prod) { | |||
| if (components) pushMeta('nue:components', components.map(uri => `${base}${uri}`).join(' ')) | |||
|
|
|||
| // misc | |||
| if (favicon) head.push(`<link rel="shortcut icon" src="${favicon}">`) | |||
| if (favicon) head.push(`<link rel="shortcut icon" type="${TYPES[extname(favicon).slice(1)]}" src="${favicon}">`) | |||
There was a problem hiding this comment.
maybe should to lower case here? otherwise, .PNG doesn't work
There was a problem hiding this comment.
Nicely spotted TYPES in nueserver.js! I think it's good to merge like this for now. I think we should add a getMime() method to nueserver later.
There was a problem hiding this comment.
maybe should to lower case here? otherwise, .PNG doesn't work
Agreed!
Nicely spotted TYPES in nueserver.js!
😉
getMime() method to nueserver
Sounds good
Not sure, but it would be probably good to expand the list with more common types.
It was quite interesting looking at a PDF in text format on the browser. Even though it is just the dev server.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #146
Adds the image type to the favicon field