Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nick/neos 358 update app to include new data generation job #702

Merged

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Dec 3, 2023

Closes NEOS-391
Closes NEOS-372

Copy link

vercel bot commented Dec 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2023 0:17am

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fba0099) 64.15% compared to head (5322b6f) 64.16%.

Files Patch % Lines
backend/services/mgmt/v1alpha1/job-service/jobs.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #702   +/-   ##
=======================================
  Coverage   64.15%   64.16%           
=======================================
  Files          78       78           
  Lines        6674     6677    +3     
=======================================
+ Hits         4282     4284    +2     
- Misses       1822     1823    +1     
  Partials      570      570           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei merged commit 973c7e9 into main Dec 3, 2023
11 of 13 checks passed
@nickzelei nickzelei deleted the nick/neos-358-update-app-to-include-new-data-generation-job branch December 3, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant