NEOS-1663: Fixes transformer configs not updating in job mapping table #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
nickzelei
changed the title
alishakawaguchi
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value we were using for the transformer column was too stable. it only took into account the case value, not the underlying config.
We make sure all transformer updates result in a fresh object, so returning the stable object reference is sufficient to trigger re-renders whenever the transformer itself is updated.
Due to this, the filterFn for the transformer needed to be updated to properly handle searches to retain the original functionality brought on by the old valueFn.
Demo: https://www.loom.com/share/6c7e422028cc40d699a6d58744976c00