Mysql and Mssql processors #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
nickzelei
reviewed
Dec 6, 2024
|
|
||
| func getSqlBatchProcessors(driver string, columns []string, columnDataTypes map[string]string, columnDefaultProperties map[string]*neosync_benthos.ColumnDefaultProperties) (*neosync_benthos.BatchProcessor, error) { | ||
| switch driver { | ||
| case sqlmanager_shared.PostgresDriver, "postgres": |
There was a problem hiding this comment.
There is a new constant in the sqlmanager_shared for the postgres driver called DefaultPostgresDriver
| func getSqlBatchProcessors(driver string, columns []string, columnDataTypes map[string]string, columnDefaultProperties map[string]*neosync_benthos.ColumnDefaultProperties) (*neosync_benthos.BatchProcessor, error) { | ||
| switch driver { | ||
| case sqlmanager_shared.PostgresDriver, "postgres": | ||
| return &neosync_benthos.BatchProcessor{NeosyncToPgx: &neosync_benthos.NeosyncToPgxConfig{Columns: columns, ColumnDataTypes: columnDataTypes, ColumnDefaultProperties: columnDefaultProperties}}, nil |
| if err != nil { | ||
| return err | ||
| } | ||
| return err |
There was a problem hiding this comment.
Hm, is this intending to return the outer error? if so, the err that is used for RetryInsertRowByRow should be renamed.
| "github.com/warpstreamlabs/bento/public/service" | ||
| ) | ||
|
|
||
| func neosyncToMssqlProcessorConfig() *service.ConfigSpec { |
There was a problem hiding this comment.
Would be nice to see tests for these things via the benthos-way of testing them where they are init'd and run through that, more like an integration test.
See the out output_sql_insert_test.go for a basic example of what I'm referring to..
nickzelei
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creates mysql and mssql processors. untangled messy sql output and insert query builder code
added default value postgres integration test