Fix postgres statements case sensitivity #3007
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3007 +/- ##
==========================================
+ Coverage 36.06% 36.11% +0.05%
==========================================
Files 344 344
Lines 39454 39476 +22
==========================================
+ Hits 14228 14257 +29
+ Misses 23571 23558 -13
- Partials 1655 1661 +6 ☔ View full report in Codecov by Sentry. |
| if redisConfig == nil { | ||
| return nil, fmt.Errorf("missing redis config. this operation requires redis.") | ||
| return nil, nil |
|
|
||
| w.RegisterWorkflow(datasync_workflow.Workflow) | ||
| w.RegisterActivity(syncActivity.Sync) | ||
| w.RegisterActivity(retrieveActivityOpts.RetrieveActivityOptions) | ||
| w.RegisterActivity(runSqlInitTableStatements.RunSqlInitTableStatements) | ||
| w.RegisterActivity(syncrediscleanup_activity.DeleteRedisHash) | ||
| w.RegisterActivity(redisCleanUpActivity) |
There was a problem hiding this comment.
I think this needs to be redisCleanUpActivity.DeleteRedisHash
| redisClient, err := neosync_redis.GetRedisClient() | ||
| if err != nil { | ||
| return nil, err | ||
| if a.redisclient == nil { |
There was a problem hiding this comment.
Okay so I'm guessing the way this works is that you are providing an empty redis client but the activity is never invoked via the workflow unless we detect redis clients, yes?
| @@ -420,7 +421,7 @@ func runRedisCleanUpActivity( | |||
| }, | |||
| HeartbeatTimeout: 1 * time.Minute, | |||
| }), | |||
| syncrediscleanup_activity.DeleteRedisHash, | |||
| redisCleanUpActivity, | |||
There was a problem hiding this comment.
Missing the .DeleteRedisHash
Slightly concerning the tests didn't catch this, but maybe it suffers the same fate as the post table sync.
fast follow: write better postgres manager integration tests