CLI sync S3 end to end integration test #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alishakawaguchi
added
Devex
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3001 +/- ##
==========================================
- Coverage 36.10% 35.95% -0.15%
==========================================
Files 344 345 +1
Lines 39476 39700 +224
==========================================
+ Hits 14252 14275 +23
- Misses 23560 23762 +202
+ Partials 1664 1663 -1 ☔ View full report in Codecov by Sentry. |
alishakawaguchi
commented
Dec 4, 2024
| @@ -0,0 +1,362 @@ | |||
| package main | |||
There was a problem hiding this comment.
copied from worker integration tests. Will eventually remove the worker one in favor of this one
alishakawaguchi
commented
Dec 4, 2024
| @@ -135,7 +134,7 @@ INSERT INTO alltypes.all_postgres_types ( | |||
| DEFAULT, | |||
| 32767, -- smallint_col | |||
| 2147483647, -- integer_col | |||
| 9223372036854775807, -- bigint_col | |||
| 922337203685477580, -- bigint_col | |||
There was a problem hiding this comment.
Max postgres bigint is 9223372036854775807 but when written to S3 and then synced to postgres causes the number to be too large. Need to investigate further
nickzelei
approved these changes
Dec 5, 2024
| "go.temporal.io/sdk/testsuite" | ||
| ) | ||
|
|
||
| type Option func(*TestWorkflowEnv) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completes NEOS-1653