NEOS-1641: Fixes stale DB Connections during Data Sync Workflow #2995
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2995 +/- ##
==========================================
+ Coverage 35.58% 36.10% +0.51%
==========================================
Files 337 343 +6
Lines 39189 39323 +134
==========================================
+ Hits 13944 14196 +252
+ Misses 23599 23477 -122
- Partials 1646 1650 +4 ☔ View full report in Codecov by Sentry. |
nickzelei
added
bug
nickzelei
changed the title
| "public.users": {Columns: []string{"id"}}, | ||
| }, resp.Msg.TableConstraints) | ||
| } | ||
| // import ( |
There was a problem hiding this comment.
did you mean to comment this out?
There was a problem hiding this comment.
Shoot, I don't think I did. I'll fix them, but we need to replace these with integration tests.
|
|
||
| func (c *ConnectionManager[T]) GetConnection( | ||
| session SessionInterface, | ||
| connection ConnectionInput, |
There was a problem hiding this comment.
might be helpful to have a few debug logs here about when it finds an existing vs when it creates a new one
There was a problem hiding this comment.
Good callout. I updated the interface to require the logger and filled it out throughout with more messages.
This forced me to pass it down further anyways and replaced a few instances where I was using the global slog.
| @@ -1573,31 +1573,32 @@ func (f *fakeEELicense) IsValid() bool { | |||
| } | |||
|
|
|||
| func executeWorkflow( | |||
| t *testing.T, | |||
| t testing.TB, | |||
| @@ -32,6 +34,10 @@ func (r *RedisTestContainer) Setup(ctx context.Context) (*RedisTestContainer, er | |||
| "docker.io/redis:7", | |||
| redis.WithSnapshotting(10, 1), | |||
| redis.WithLogLevel(redis.LogLevelVerbose), | |||
| testcontainers.WithWaitStrategy( | |||
| wait.ForLog("* Ready to accept connections"), | |||
| wait.ForExposedPort(), | |||
There was a problem hiding this comment.
This seems to have fixed the redis container flakiness.
nickzelei
deleted the
nick/neos-1641-investigate-postgres-stale-connections
branch
This is a pretty large refactor that does a few things: