Neosync Interval and Interval Array type #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alishakawaguchi
added
enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2993 +/- ##
==========================================
+ Coverage 35.57% 35.77% +0.20%
==========================================
Files 337 342 +5
Lines 39120 39529 +409
==========================================
+ Hits 13915 14141 +226
- Misses 23574 23729 +155
- Partials 1631 1659 +28 ☔ View full report in Codecov by Sentry. |
nickzelei
approved these changes
Nov 26, 2024
| return v | ||
| default: | ||
| // Check if the type implements Value() method | ||
| if valuer, ok := v.(neosynctypes.NeosyncAdapter); ok { |
There was a problem hiding this comment.
Could further slim this down by having a NeosyncPgxValuer() interface that only calls out the ValuePgx function. I think that's all this thing needs anyways.
| @@ -189,12 +201,18 @@ func (g *neosyncInput) Read(ctx context.Context) (*service.Message, service.AckF | |||
| }, nil | |||
| } | |||
| } | |||
|
|
|||
| registry := neosynctypes.NewTypeRegistry(g.logger) | |||
There was a problem hiding this comment.
Should this be registered every time or just during init?
| valuesMap := map[string]any{} | ||
| for col, val := range row { | ||
| if len(val) == 0 { | ||
| valuesMap[col] = nil | ||
| } else { | ||
| valuesMap[col] = val | ||
| newVal, err := registry.Unmarshal(val) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes interval type in javascript transformer to an object instead of a string