Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1643: Integrates JobHooks into Data Sync Workflow #2991

Merged
merged 11 commits into from
Nov 25, 2024

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Nov 25, 2024

  • Adds jobhooks activities for pre/post sync hooks to data sync workflow
  • Updates worker to utilize generic EEInterface and wraps neosync cloud up into that for simplicity

Copy link

linear bot commented Nov 25, 2024

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 9:38pm

@nickzelei nickzelei self-assigned this Nov 25, 2024
@nickzelei nickzelei added the enhancement New feature or request label Nov 25, 2024
@nickzelei nickzelei changed the title NEOS-1643: wire up job hooks to worker NEOS-1643: Implements JobHooks into Data Sync Workflow Nov 25, 2024
@nickzelei nickzelei changed the title NEOS-1643: Implements JobHooks into Data Sync Workflow NEOS-1643: Integrates JobHooks into Data Sync Workflow Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 61.01695% with 69 lines in your changes missing coverage. Please review.

Project coverage is 35.56%. Comparing base (0f405b0) to head (dbaa721).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...datasync/activities/jobhooks-by-timing/activity.go 72.72% 22 Missing and 8 partials ⚠️
internal/ee/license/cascade.go 0.00% 9 Missing ⚠️
worker/pkg/workflows/datasync/workflow/workflow.go 71.87% 6 Missing and 3 partials ⚠️
worker/internal/cmds/worker/serve/serve.go 0.00% 8 Missing ⚠️
internal/ee/license/cloud.go 0.00% 6 Missing ⚠️
...nc/activities/run-sql-init-table-stmts/activity.go 0.00% 4 Missing ⚠️
...run-sql-init-table-stmts/init-statement-builder.go 71.42% 2 Missing ⚠️
backend/internal/cmds/mgmt/serve/connect/cmd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2991      +/-   ##
==========================================
+ Coverage   35.44%   35.56%   +0.11%     
==========================================
  Files         334      337       +3     
  Lines       38958    39120     +162     
==========================================
+ Hits        13810    13912     +102     
- Misses      23527    23576      +49     
- Partials     1621     1632      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei marked this pull request as ready for review November 25, 2024 21:30
@nickzelei nickzelei merged commit 65cc55e into main Nov 25, 2024
10 checks passed
@nickzelei nickzelei deleted the nick/neos-1643-wire-up-job-hooks-to-worker branch November 25, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants