Centralizes some frontend deps to workspace, updates knip #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
nickzelei
commented
Oct 1, 2024
Comment on lines
+151
to
+152
| const trusted = new Uint8Array(Buffer.from(signature, 'ascii')); | ||
| const untrusted = new Uint8Array(Buffer.from(untrustedSignature, 'ascii')); |
There was a problem hiding this comment.
this was a new build error. the node docs say a buffer is allowed but I think the nodejs types might be broken or something. either way this should work just fine.
alishakawaguchi
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralizes some shared dev dependences between app and sdk.
Moves knip to root of workspace for frontend/