Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1485: reduce workflow checkaccountstatus for paid accounts #2752

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Sep 27, 2024

The workflow.go file is easier to read if you hide whitespace.

@nickzelei nickzelei added the enhancement New feature or request label Sep 27, 2024
Copy link

linear bot commented Sep 27, 2024

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 11:38pm

Copy link

github-actions bot commented Sep 27, 2024

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 27, 2024, 11:38 PM

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 60.71429% with 22 lines in your changes missing coverage. Please review.

Project coverage is 36.85%. Comparing base (d58db93) to head (4f0686f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ices/mgmt/v1alpha1/user-account-service/billing.go 0.00% 11 Missing ⚠️
worker/pkg/workflows/datasync/workflow/workflow.go 75.00% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2752      +/-   ##
==========================================
+ Coverage   36.83%   36.85%   +0.01%     
==========================================
  Files         285      285              
  Lines       26673    26674       +1     
==========================================
+ Hits         9825     9830       +5     
+ Misses      15551    15550       -1     
+ Partials     1297     1294       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei marked this pull request as ready for review September 27, 2024 22:45
@nickzelei nickzelei force-pushed the nick/neos-1485-reduce-workflow-checkaccountstatus-for-paid-accounts branch from f6b826a to 6eab4df Compare September 27, 2024 22:58
@nickzelei nickzelei merged commit 391e0ee into main Sep 27, 2024
18 checks passed
@nickzelei nickzelei deleted the nick/neos-1485-reduce-workflow-checkaccountstatus-for-paid-accounts branch September 27, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants