NEOS-1489 Fix default being converted to database DEFAULT #2741
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
===========================================
+ Coverage 11.51% 36.64% +25.12%
===========================================
Files 281 282 +1
Lines 26096 26201 +105
===========================================
+ Hits 3006 9602 +6596
+ Misses 22653 15309 -7344
- Partials 437 1290 +853 ☔ View full report in Codecov by Sentry. |
| @@ -148,8 +183,10 @@ func Test_ProcessorConfigEmptyJavascript(t *testing.T) { | |||
| queryMap := map[string]map[tabledependency.RunType]string{ | |||
| "public.users": {tabledependency.RunTypeInsert: ""}, | |||
| } | |||
| logger := slog.New(slog.NewTextHandler(os.Stdout, nil)) | |||
There was a problem hiding this comment.
for the future, if you don't want this to log during the tests you can pass in io.Discard instead of os.Stdout.
You can search the codebase for discardLogger to see examples that I've been creating.
There was a problem hiding this comment.
I think at some point we probably want to have a "test logger" that we can pass in and maybe enable it if we use the -v flag for tests or something. Would be a nice QoL
No description provided.