Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1464 Support MYSQL Bit, Date and Json types #2723

Merged
merged 12 commits into from
Sep 20, 2024

Conversation

alishakawaguchi
Copy link
Contributor

No description provided.

@alishakawaguchi alishakawaguchi added the enhancement New feature or request label Sep 19, 2024
@alishakawaguchi alishakawaguchi self-assigned this Sep 19, 2024
Copy link

linear bot commented Sep 19, 2024

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 3:55pm

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 76.56250% with 30 lines in your changes missing coverage. Please review.

Project coverage is 36.86%. Comparing base (763d6b3) to head (cf29228).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/mysql/mysql.go 80.00% 7 Missing and 3 partials ⚠️
worker/pkg/query-builder/query-builder.go 30.76% 8 Missing and 1 partial ⚠️
worker/pkg/benthos/sql/output_sql_insert.go 25.00% 6 Missing ⚠️
backend/pkg/sqlmanager/sql-manager.go 0.00% 2 Missing ⚠️
internal/sqlscanners/scanners.go 95.74% 1 Missing and 1 partial ⚠️
worker/pkg/benthos/sql/input_sql_raw.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2723      +/-   ##
==========================================
+ Coverage   36.66%   36.86%   +0.19%     
==========================================
  Files         274      276       +2     
  Lines       25737    25822      +85     
==========================================
+ Hits         9437     9519      +82     
+ Misses      15031    15026       -5     
- Partials     1269     1277       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

} else if gotypeutil.IsMap(a) {
bits, err := gotypeutil.MapToJson(a)
if err != nil {
gval = append(gval, a)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log the err yo

Copy link
Member

@nickzelei nickzelei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@alishakawaguchi alishakawaguchi merged commit 190f409 into main Sep 20, 2024
10 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/mysql-types branch September 20, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants