Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds date label to benthos metrics #2698

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Adds date label to benthos metrics #2698

merged 3 commits into from
Sep 16, 2024

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Sep 16, 2024

This will give us more accurate reporting for daily and monthly metrics going forward.
Will also allow us to switch from delta to cumulative metrics if we desire.

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 5:34pm

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.02%. Comparing base (dad3f03) to head (d5978f0).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../activities/gen-benthos-configs/benthos-builder.go 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (dad3f03) and HEAD (d5978f0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (dad3f03) HEAD (d5978f0)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2698      +/-   ##
==========================================
- Coverage   36.48%   30.02%   -6.47%     
==========================================
  Files         274      274              
  Lines       25629    25633       +4     
==========================================
- Hits         9351     7696    -1655     
- Misses      15011    16899    +1888     
+ Partials     1267     1038     -229     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei added the enhancement New feature or request label Sep 16, 2024
@nickzelei nickzelei marked this pull request as ready for review September 16, 2024 17:45
@nickzelei nickzelei merged commit b4e24cb into main Sep 16, 2024
8 of 11 checks passed
@nickzelei nickzelei deleted the nick/adds-date-metrics branch September 16, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants