Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1426 Fix SQL Server bit data type in sync #2646

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

alishakawaguchi
Copy link
Contributor

No description provided.

@alishakawaguchi alishakawaguchi added the bug Something isn't working label Sep 9, 2024
@alishakawaguchi alishakawaguchi self-assigned this Sep 9, 2024
Copy link

linear bot commented Sep 9, 2024

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 9:35pm

@alishakawaguchi alishakawaguchi changed the base branch from main to alisha/mssql-datatypes September 9, 2024 19:58
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 62.90323% with 23 lines in your changes missing coverage. Please review.

Project coverage is 37.48%. Comparing base (a0ed7fc) to head (23ad3e3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
worker/pkg/benthos/sql/output_sql_insert.go 0.00% 11 Missing ⚠️
worker/pkg/query-builder/query-builder.go 12.50% 4 Missing and 3 partials ⚠️
internal/sqlserver/utils.go 88.37% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2646      +/-   ##
==========================================
- Coverage   37.59%   37.48%   -0.12%     
==========================================
  Files         270      270              
  Lines       25177    25201      +24     
==========================================
- Hits         9466     9446      -20     
- Misses      14397    14442      +45     
+ Partials     1314     1313       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from alisha/mssql-datatypes to main September 9, 2024 20:37
@alishakawaguchi alishakawaguchi merged commit c7769fd into main Sep 9, 2024
8 of 10 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/mssql-bit-bug branch September 9, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants