-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEOS-1415: re enable team accounts in oss #2632
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2632 +/- ##
==========================================
+ Coverage 37.66% 37.68% +0.01%
==========================================
Files 266 266
Lines 24865 24867 +2
==========================================
+ Hits 9366 9370 +4
+ Misses 14190 14189 -1
+ Partials 1309 1308 -1 ☔ View full report in Codecov by Sentry. |
@@ -230,6 +230,9 @@ func (s *Service) CreateTeamAccount( | |||
if !s.cfg.IsAuthEnabled { | |||
return nil, nucleuserrors.NewForbidden("unable to create team account as authentication is not enabled") | |||
} | |||
if s.cfg.IsNeosyncCloud { | |||
return nil, nucleuserrors.NewForbidden("creating team accounts in Neosync Cloud is not currently enabled. Please contact us to gain access to a team account.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first makes it sound like we don't support it at all when in reality they just need to contact us for it.
Maybe just say, "Please contact us to create a team account."
Eventually, it'll just allow them to upgrade directly to it once the upgrade flow is set up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, this was moreso to avoid someone circumventing the UI
No description provided.