Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1415: re enable team accounts in oss #2632

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

nickzelei
Copy link
Member

No description provided.

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 8:51pm

Copy link

linear bot commented Sep 6, 2024

@nickzelei nickzelei self-assigned this Sep 6, 2024
@nickzelei nickzelei added the bug Something isn't working label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.68%. Comparing base (b3a8ce3) to head (4fac83f).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...rvices/mgmt/v1alpha1/user-account-service/users.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2632      +/-   ##
==========================================
+ Coverage   37.66%   37.68%   +0.01%     
==========================================
  Files         266      266              
  Lines       24865    24867       +2     
==========================================
+ Hits         9366     9370       +4     
+ Misses      14190    14189       -1     
+ Partials     1309     1308       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei merged commit 650ac32 into main Sep 6, 2024
11 of 14 checks passed
@nickzelei nickzelei deleted the nick/neos-1415-re-enable-team-accounts-in-oss branch September 6, 2024 21:01
@@ -230,6 +230,9 @@ func (s *Service) CreateTeamAccount(
if !s.cfg.IsAuthEnabled {
return nil, nucleuserrors.NewForbidden("unable to create team account as authentication is not enabled")
}
if s.cfg.IsNeosyncCloud {
return nil, nucleuserrors.NewForbidden("creating team accounts in Neosync Cloud is not currently enabled. Please contact us to gain access to a team account.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first makes it sound like we don't support it at all when in reality they just need to contact us for it.

Maybe just say, "Please contact us to create a team account."

Eventually, it'll just allow them to upgrade directly to it once the upgrade flow is set up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this was moreso to avoid someone circumventing the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants