Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1395 Improve the readability of TSQL query qualifier #2607

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

alishakawaguchi
Copy link
Contributor

No description provided.

@alishakawaguchi alishakawaguchi added the Devex Created by Linear-GitHub Sync label Sep 4, 2024
@alishakawaguchi alishakawaguchi self-assigned this Sep 4, 2024
Copy link

linear bot commented Sep 4, 2024

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 4:53pm

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.

Project coverage is 37.63%. Comparing base (3fd37fe) to head (388c476).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
worker/pkg/query-builder2/tsql/query-qualifier.go 92.59% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2607      +/-   ##
==========================================
- Coverage   37.64%   37.63%   -0.01%     
==========================================
  Files         266      266              
  Lines       24832    24834       +2     
==========================================
- Hits         9347     9346       -1     
- Misses      14176    14177       +1     
- Partials     1309     1311       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nickzelei nickzelei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thank you for adding more documentation to this.

@alishakawaguchi alishakawaguchi merged commit e591c93 into main Sep 4, 2024
9 of 10 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/neos-1395-antlr branch September 4, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devex Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants