Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configuration to PHP #5

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Move configuration to PHP #5

merged 2 commits into from
Jul 4, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Jul 3, 2020

Subject

Allow loading services without XML extension.

@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #5 into main will increase coverage by 8.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main       #5      +/-   ##
============================================
+ Coverage     34.01%   42.70%   +8.68%     
  Complexity       68       68              
============================================
  Files            13       16       +3     
  Lines           244      281      +37     
============================================
+ Hits             83      120      +37     
  Misses          161      161              
Impacted Files Coverage Δ Complexity Δ
...rc/DependencyInjection/NucleosAllInklExtension.php 87.50% <100.00%> (ø) 6.00 <0.00> (ø)
src/Resources/config/block.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/commands.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)
src/Resources/config/services.php 100.00% <100.00%> (ø) 0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48eba6...120f815. Read the comment docs.

@core23 core23 merged commit 6244291 into main Jul 4, 2020
@core23 core23 deleted the php-files branch July 4, 2020 13:10
core23 added a commit that referenced this pull request Nov 5, 2020
…checkout-v2.2.0

Bump actions/checkout from v1 to v2.2.0
@core23 core23 removed the automerge label Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant