Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NSBH disk mass fit #360

Merged

Conversation

atoivonen13
Copy link
Contributor

use BH spin instead of chi_eff for NSBH disk mass fit

@atoivonen13
Copy link
Contributor Author

We need to decide whether to modify the current function chieff2risco, or just pass the spin of the BH to that function in this case (as I have done in the PR so far)

@mcoughlin mcoughlin requested a review from tsunhopang April 30, 2024 18:39
@tsunhopang
Copy link
Collaborator

as @atoivonen13 suggested, we would indeed need to adjust the usage of the risco, since in the remnant_disk_mass_fitting we are using it as the normalized one, but in dynamic_mass_fitting we are using it as the risco

@atoivonen13
Copy link
Contributor Author

atoivonen13 commented May 8, 2024

@tsunhopang In the end, the only difference comes down to passing chi_eff or chi_bh. Normally, I would simply change the function to take an argument of chi instead of chi_eff and leave a function description saying passing chi_eff gets you risco while chi_bh gets you the normalized spin. However, we would also then probably want to rename the function chieff2risco to chi2risco, which could be an issue for any other uses of this function. Otherwise we can simply leave a note in the description saying passing chi_bh gives you the normalized risco. Duplicating the function seems unnecessary as the code is the same.

@tsunhopang
Copy link
Collaborator

@atoivonen13 could u take a look and see why the two unit tests are failing? After these are fixed I will have this PR merged

Copy link
Collaborator

@tsunhopang tsunhopang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tsunhopang tsunhopang merged commit 02466ad into nuclear-multimessenger-astronomy:main Jun 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants