Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml #329

Conversation

sahiljhawar
Copy link
Member

replaced the following lines:

[tool.setuptools]
packages = ["nmma"]

to ensure that feedstock CI works

@sahiljhawar sahiljhawar marked this pull request as draft March 5, 2024 13:36
@sahiljhawar sahiljhawar requested a review from Theodlz March 5, 2024 13:39
@Theodlz Theodlz marked this pull request as ready for review March 5, 2024 16:31
Copy link
Collaborator

@Theodlz Theodlz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please just make sure that the tests still run, and that the command to update the version of NMMA still works too

@sahiljhawar
Copy link
Member Author

@Theodlz everything works fine. It’s just that we recently had to manually run the conda feedstock and the CI was failing due to the packaging issue. But with the newer version, it works fine

See here for more details: conda-forge/nmma-feedstock#14

@Theodlz
Copy link
Collaborator

Theodlz commented Mar 5, 2024

Sounds good! LGTM, you can merge when you are ready.

@sahiljhawar sahiljhawar merged commit 1ee58e2 into nuclear-multimessenger-astronomy:main Mar 5, 2024
4 checks passed
@sahiljhawar sahiljhawar deleted the restrict-python branch April 10, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants