-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doker file for NMMA #322
Doker file for NMMA #322
Conversation
Dockerfile to create and image for NMMA.
@FabioRagosta Any specific reason to change minimum |
@FabioRagosta Along with this can you provide CI/CD pipeline to publish the image on dockerhub? If you need help you can see the example Docker CI here: build-deploy-container.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FabioRagosta, thanks for opening this PR! Just a few questions on the details.
|
@FabioRagosta add it to the workflows folder through a commit. Zip file is of no use for the end user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @sahiljhawar, do you think the .yml file should be located with the others in the .github/workflows
directory, or is it good where it is?
@bfhealy I think it should be in the workflows directory. Only then the image will be pushed to Dockerhub |
No need of docker CI |
25fe95e
into
nuclear-multimessenger-astronomy:main
nmma_docker.zip
This docker file allows to create an image of Ubunti20.04 Operative System and to install nmma and all the needed dependeces.