Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doker file for NMMA #322

Merged
merged 10 commits into from
Feb 19, 2024

Conversation

FabioRagosta
Copy link
Contributor

nmma_docker.zip

This docker file allows to create an image of Ubunti20.04 Operative System and to install nmma and all the needed dependeces.

@sahiljhawar
Copy link
Member

@FabioRagosta Any specific reason to change minimum astropy version?

@sahiljhawar
Copy link
Member

@FabioRagosta Along with this can you provide CI/CD pipeline to publish the image on dockerhub? If you need help you can see the example Docker CI here: build-deploy-container.yml

Copy link
Collaborator

@bfhealy bfhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FabioRagosta, thanks for opening this PR! Just a few questions on the details.

Dockerfile Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
@FabioRagosta
Copy link
Contributor Author

@FabioRagosta Along with this can you provide CI/CD pipeline to publish the image on dockerhub? If you need help you can see the example Docker CI here: build-deploy-container.yml
I added the CI/CD pipeline in this zip.
nmma_docker.zip

@sahiljhawar
Copy link
Member

sahiljhawar commented Feb 15, 2024

@FabioRagosta add it to the workflows folder through a commit. Zip file is of no use for the end user.

@sahiljhawar sahiljhawar requested a review from bfhealy February 17, 2024 16:01
Copy link
Collaborator

@bfhealy bfhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @sahiljhawar, do you think the .yml file should be located with the others in the .github/workflows directory, or is it good where it is?

@sahiljhawar
Copy link
Member

@bfhealy I think it should be in the workflows directory. Only then the image will be pushed to Dockerhub

@sahiljhawar
Copy link
Member

No need of docker CI

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
build-deploy-container_nmma.yml Outdated Show resolved Hide resolved
@sahiljhawar sahiljhawar merged commit 25fe95e into nuclear-multimessenger-astronomy:main Feb 19, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants