Multimessenger Inference updates #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bu2022Ye is only developed on a specific grid. The current prior exceeds the grid, thus it should be modified. Additionally, if no DOI can be assigned, now it will be set to the PERMANENTDOI by default.
Change priors for Bu2022Ye.prior
Previously, the GRB model did not get the filters passed down from the sampler. This is now fixed, additionally the GenericCombineLightCurveModel is introduced for the joint inference likelihood.
Pass filter to GRB model
tsunhopang
reviewed
Oct 10, 2023
| @@ -369,7 +368,7 @@ def observation_angle_conversion(self, parameters): | |||
| def generate_lightcurve(self, sample_times, parameters): | |||
| if self.parameter_conversion: | |||
| new_parameters = parameters.copy() | |||
| new_parameters, _ = self.parameter_conversion(new_parameters, []) | |||
There was a problem hiding this comment.
isn't the parameter_conversion for MMA takes not only the parameters dict but also the parameter keys?
There was a problem hiding this comment.
For my setup self.parameter_conversion points to MultimessengerConversion.convert_to_multimessenger_parameters in joint/conversion.py line 468 and that function takes only the parameters as dict. i get an error when i leave the second argument there
tsunhopang
reviewed
Oct 10, 2023
nmma/joint/likelihood.py
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| import numpy as np | |||
|
|
|||
| from ..em.model import SVDLightCurveModel, KilonovaGRBLightCurveModel | |||
| from ..em.model import SVDLightCurveModel, KilonovaGRBLightCurveModel, GRBLightCurveModel, GenericCombineLightCurveModel | |||
There was a problem hiding this comment.
Maybe remove the importing of KilonovaGRBLightCurveModel
|
@haukekoehn Ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes that previously obstructed multimessenger inference.