check and set trigger time #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbarna
requested changes
Oct 6, 2023
nmma/em/analysis.py
Outdated
|
|
||
| trigger_time = args.trigger_time | ||
| print("trigger_time is not provided, analysis will continue using the time of first data point") #maybe change it to warning instead of print | ||
| trigger_time=min_time #For now this will only work if data file is not in JSON or try block is executed successfully. |
There was a problem hiding this comment.
We should probably support json lightcurves, at least in the format that nmma itself creates from injections
There was a problem hiding this comment.
But yeah, this seems to be in line with what I was thinking for handling when a trigger time wasn't provided
There was a problem hiding this comment.
@tylerbarna Do you have any json LC for test?
There was a problem hiding this comment.
@tylerbarna Do you have any json LC for test?
tylerbarna
reviewed
Oct 6, 2023
Co-authored-by: Tyler Barna <57914086+tylerbarna@users.noreply.github.com>
Co-authored-by: Tyler Barna <57914086+tylerbarna@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #256, incomplete
@tylerbarna Can you have a look at this?
Do not merge!