Changes to gwem_resampling_utils #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the luminosity_to_redshift function of bilby doesn't scale well, a custom version of that function is added that is faster. Overall, the timesave is small, but until the luminosity_distance_to_redshift functionin bilby is not improved, we should refrain from using it.
|
@tsunhopang Will you have time to review this? |
|
LGTM, waiting for the checking results |
When resampling, the EM posterior now can also only contain the total ejecta mass, instead of having the seperate wind and dynamical mass. This is required, because in some GRB models only the total mass is given.
haukekoehn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the luminosity_distance_to_redshift function of bilby doesn't scale well, a custom version of that function is added that is faster. Overall, the timesave is small, but until the luminosity_distance_to_redshift functionin bilby is not improved, we should refrain from using it.