Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python-package.yml #193

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Update python-package.yml #193

merged 1 commit into from
Aug 7, 2023

Conversation

sahiljhawar
Copy link
Member

Fixed syntax

mcoughlin
mcoughlin approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoughlin mcoughlin merged commit 700b500 into nuclear-multimessenger-astronomy:main Aug 7, 2023
@sahiljhawar
Copy link
Member Author

@mcoughlin can you redo the merge? The tests (at coverage) fails

@mcoughlin
Copy link
Member

@sahiljhawar we can just do a new PR right? It seems like the code at least ran which was progress.

@sahiljhawar
Copy link
Member Author

sahiljhawar commented Aug 7, 2023 •
edited
Loading

@mcoughlin Okay. Still trying to figure out how this works. Yeah it worked until the tests and failed after

@sahiljhawar sahiljhawar deleted the sahiljhawar-patch-1 branch August 7, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoughlin mcoughlin mcoughlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahiljhawar @mcoughlin