Mob plat/bump flutter 2.10 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoiacovini
reviewed
May 17, 2022
test/nuvigator_test.dart
Outdated
Comment on lines
585
to
586
| // Should rebuild NuRouter (going back to secondNestedScreen2) | ||
| expect(find.text('SecondNestedScreen2'), findsOneWidget); |
There was a problem hiding this comment.
🤔 This looks odd, why did this test break?
There was a problem hiding this comment.
It was just not founding the expected screen. We debugged this, and we dont know how the test was passing before....
There was a problem hiding this comment.
I did a bisect in flutter versions and discovered this commit caused the test to break.
Adding a TickerMode with enabled: false fixed the problem.
Thanks @leoiacovini for the help
There was a problem hiding this comment.
Also, just for the sake of clarity: It seems that it didn't break the behavior when running the code in reality, instead it was just the test that boke
renatoaugustofranca
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the bump of some dependencies, for flutter version 2.10