Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #103 #104

Merged
merged 2 commits into from
Oct 11, 2022
Merged

fix #103 #104

merged 2 commits into from
Oct 11, 2022

Conversation

realshovanshah
Copy link
Contributor

@realshovanshah realshovanshah commented Aug 31, 2022 •
edited
Loading

Description

This seems to be the cause of the problem but I think more tests need to be added.

Todo

  • Add tests

@realshovanshah
fix #103
182cccb 
### Description

This seems to be the cause of the problem but I think more tests need to be added.

### Todo

- [ ] Add tests?
@realshovanshah realshovanshah requested review from leoiacovini and removed request for leoiacovini August 31, 2022 02:36
@leoiacovini
Copy link
Collaborator

Thanks for the contribution!

Would you mind adding a test for the case here?

@realshovanshah
Copy link
Contributor Author

I think we can merge now : ) @leoiacovini

@realshovanshah realshovanshah deleted the realshovanshah-patch-1 branch October 11, 2022 11:14
@realshovanshah realshovanshah restored the realshovanshah-patch-1 branch October 11, 2022 11:15
@realshovanshah
Copy link
Contributor Author

Sorry, didn't know renaming would close the PR 😅

@leoiacovini leoiacovini merged commit eca88fb into master Oct 11, 2022
@leoiacovini leoiacovini deleted the realshovanshah-patch-1 branch October 11, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoiacovini leoiacovini leoiacovini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realshovanshah @leoiacovini