Port project to Github Actions and bump dependencies to better support python 3.9 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 94.69% 94.21% -0.48%
==========================================
Files 25 34 +9
Lines 1507 2109 +602
Branches 203 281 +78
==========================================
+ Hits 1427 1987 +560
- Misses 48 84 +36
- Partials 32 38 +6
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This reverts commit 88c9766.
Comment on lines
+4
to
+6
| on: | ||
| release: | ||
| types: [published] |
There was a problem hiding this comment.
This is a change in behavior, but seems OK: publish the package in PyPI when there is a published release on GitHub. We can test how this will work with tags and protected branches.
fpingas
changed the title
|
Implemented in #227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Todo list
Background context
CircleCI is not working consistently and the package takes ages to install in python 3.9 due to its dependency locks.
Description of the changes proposed in the pull request
Port CircleCI workflows to Github Action workflows, one
push, for running test and code checks at every push for code quality, and onepublish, for publishing the package when a new github release is published.This PR also updates the maximum allowed scikit-learn dependency so it installs quicker in 3.9.