Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support absolute path for all configuration parameters #681

Closed
kedare opened this issue Oct 26, 2021 · 2 comments
Closed

Support absolute path for all configuration parameters #681

kedare opened this issue Oct 26, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@kedare
Copy link

kedare commented Oct 26, 2021

Describe what you would like to achieve
Currently, the log and prefix list paths cannot be specified absolute, they are all prepended by this.config.volume.
It's not a good practice to force this kind of behaviour as it prevent log paths to be specified on a proper directory in /var/log and the prefix list in a proper configuration directory like /etc/bgpalerter (it doesn't make much sense to force it in the data directory)

Describe why the current solution (if any) is not satisfactory
Inflexible, force bad practice, can be workaround with symlinks probably (but it makes the setup harder to understand)

Provide an example
N/R

Your information
N/R

@kedare kedare added the enhancement New feature or request label Oct 26, 2021
@massimocandela
Copy link
Member

Hello @kedare,

I have currently several installations where logs are in /var/log/ and data and configurations are on other directories. If you specify an absolute path in logging.direcotry this will be respected. The same goes for monitoredPrefixesFiles and alertDataDirectory.

The volume parameter is used to override the default behavior, mostly in two situations: (1) when you want to create "virtual environments", e.g., you want to have a single installation of BGPalerter swapping multiple instances operating confined in a different directory each (with relative paths); or (2) when you are using docker and you want to create a persistent volume.

The volume parameter is not set by default by BGPalerter and it is not contained in the example configuration because it is a bit of a corner use case. I would suggest you to remove it from your config. However, I will improve the documentation to make this clear! Thanks for reporting

@kedare
Copy link
Author

kedare commented Oct 26, 2021

Okay indeed it's not clear that the --d is not required, not just for the data directory and that it modifies the behavior of all the path parameters in the configuration file, I will make a try tomorrow without, indeed it would be nice to add some details about this behavior in the documentation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants