Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable kernel interrupt on windows #593

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

lgeiger
Copy link
Member

@lgeiger lgeiger commented Jan 23, 2017

Unfortunately windows doesn't support signals.

Node.js docs:

Note: Windows does not support sending signals, but Node.js offers some emulation with process.kill(), and ChildProcess.kill(). Sending signal 0 can be used to test for the existence of a process. Sending SIGINT, SIGTERM, and SIGKILL cause the unconditional termination of the target process.

Closes #592

@nikitakit
Copy link
Contributor

This incompatibility with Windows is certainly a good catch!

Do you think it would be worthwhile to implement a workaround using the Windows event APIs, rather than simply declaring interruption to be unsupported?

IIRC the notebook server on Windows supports interrupting kernels -- and it looks like the code responsible can be found here, here, and here.

Note that I don't use Windows myself, so I won't be able to evaluate/test this.

@lgeiger
Copy link
Member Author

lgeiger commented Jan 23, 2017

Thanks for the links! Implementing a workaround would definitely be a better solution and we could use it in nteract as well.

That said, I'm not using Windows either and have no knowledge about Windows events so I won't implement this any time soon.

I guess disabling the feature is the best we can do so far.

@nikitakit
Copy link
Contributor

@lgeiger That's fair. It then makes sense to keep an issue filed in case someone with Windows wants to contribute a workaround.

@lgeiger lgeiger added the bug 🐛 For unexpected issues label Jan 25, 2017
@lgeiger
Copy link
Member Author

lgeiger commented Jan 25, 2017

It then makes sense to keep an issue filed in case someone with Windows wants to contribute a workaround.

Totally agree 👍
Would you like to open one?

@rgbkrk rgbkrk merged commit 8ba7212 into nteract:master Jan 25, 2017
@lgeiger lgeiger deleted the windows-interrupt branch January 25, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 For unexpected issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants