Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text/markdown code inspect results #562

Merged
merged 1 commit into from
Dec 27, 2016

Conversation

BenRussert
Copy link
Member

One line change to inspect.js to allow mimetype text/markdown for IJulia and maybe others.
#561.

@rgbkrk
Copy link
Member

rgbkrk commented Dec 27, 2016

Oh interesting, we could be using the transformime stuff here in general for inspection results to show rich results.

@rgbkrk
Copy link
Member

rgbkrk commented Dec 27, 2016

I'll leave this to @lgeiger to review and merge. Thanks for the contribution @BenRussert!

Copy link
Member

@lgeiger lgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo that's great 🎉

@lgeiger lgeiger merged commit 4372845 into nteract:master Dec 27, 2016
@lgeiger
Copy link
Member

lgeiger commented Dec 27, 2016

Oh interesting, we could be using the transformime stuff here in general for inspection results to show rich results.

That's exactly what we're doing 👍

@rgbkrk
Copy link
Member

rgbkrk commented Dec 28, 2016

That's exactly what we're doing

Ah, cool. What was the whitelisting/conditional for?

@lgeiger
Copy link
Member

lgeiger commented Dec 28, 2016

For text/plain we split the first line from the rest, so it can be displayed as a heading when the inspector is collapsed.

@BenRussert BenRussert deleted the inspect-markdown branch December 28, 2016 00:08
@lgeiger
Copy link
Member

lgeiger commented Dec 29, 2016

@BenRussert Thanks again for your PR. Would you like to help us maintain Hydrogen?

@BenRussert
Copy link
Member Author

@lgeiger oh, cool! Hey I'll do what I can, but I'll have to learn as I go as I did here.

@rgbkrk
Copy link
Member

rgbkrk commented Dec 30, 2016

Welcome to the nteract party! 🎉

@lgeiger
Copy link
Member

lgeiger commented Dec 30, 2016

That's great 🎉

@BenRussert
Copy link
Member Author

@lgeiger @rgbkrk Slack link doesnt seem to work. I've never used before so I'm not sure if the issue is on my end.

@rgbkrk
Copy link
Member

rgbkrk commented Jan 21, 2017

Our DNS is switching over, feel free to use https://slackin-egwcornswi.now.sh/ to sign up for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants