Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace func as key with str #22

Merged
merged 3 commits into from
Sep 25, 2022
Merged

Replace func as key with str #22

merged 3 commits into from
Sep 25, 2022

Conversation

nstarman
Copy link
Owner

@nstarman nstarman commented Sep 25, 2022

Description

NumPy does weird function replacement in a lot of places, so lookup tables using the function don't work. Thankfully all the substituted functions share the same module and name, so these must be the lookup keys.

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

@nstarman nstarman added enhancement New feature or request refactoring labels Sep 25, 2022
@nstarman nstarman added this to the v0.1 milestone Sep 25, 2022
@nstarman nstarman force-pushed the replace-func-as-key-with-str branch from 4bf27fd to 74e1fba Compare September 25, 2022 03:50
@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Base: 94.24% // Head: 93.67% // Decreases project coverage by -0.57% ⚠️

Coverage data is based on head (09fe82e) compared to base (81efd58).
Patch coverage: 93.75% of modified lines in pull request are covered.

❗ Current head 09fe82e differs from pull request most recent head bb383c0. Consider uploading reports for the commit bb383c0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   94.24%   93.67%   -0.58%     
==========================================
  Files           7        7              
  Lines         226      237      +11     
==========================================
+ Hits          213      222       +9     
- Misses         13       15       +2     
Impacted Files Coverage Δ
src/overload_numpy/overload.py 89.01% <89.47%> (-1.24%) ⬇️
src/overload_numpy/assists.py 100.00% <100.00%> (ø)
src/overload_numpy/constraints.py 100.00% <100.00%> (ø)
src/overload_numpy/mixin.py 80.95% <100.00%> (+2.00%) ⬆️
src/overload_numpy/npinfo.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nstarman nstarman force-pushed the replace-func-as-key-with-str branch 2 times, most recently from 301360e to 3d1f0b8 Compare September 25, 2022 17:38
@nstarman nstarman marked this pull request as ready for review September 25, 2022 17:39
@nstarman nstarman force-pushed the replace-func-as-key-with-str branch from 3d1f0b8 to 09fe82e Compare September 25, 2022 17:45
Signed-off-by: nstarman <nstarkman@protonmail.com>
Signed-off-by: nstarman <nstarkman@protonmail.com>
Signed-off-by: nstarman <nstarkman@protonmail.com>
@nstarman nstarman force-pushed the replace-func-as-key-with-str branch from 09fe82e to bb383c0 Compare September 25, 2022 17:57
@nstarman nstarman merged commit 182d994 into main Sep 25, 2022
@nstarman nstarman deleted the replace-func-as-key-with-str branch September 25, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant