Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plutus-apps repo location #72

Merged
merged 7 commits into from
Jan 21, 2022
Merged

Fix plutus-apps repo location #72

merged 7 commits into from
Jan 21, 2022

Conversation

bjing
Copy link
Contributor

@bjing bjing commented Jan 11, 2022

No description provided.

@joaquimgamero
Copy link

As a side comment, it looks like other OS instructions need to update the repo url also.

@bjing
Copy link
Contributor Author

bjing commented Jan 11, 2022

Thanks @joaquimgamero , i'll take a look at the other ones when I get a bit of time.

@nstankov-bg
Copy link
Owner

Anybody interested in updating that URL repo-wise?

@nstankov-bg nstankov-bg self-requested a review January 17, 2022 15:49
nrkramer
nrkramer suggested changes Jan 17, 2022
View reviewed changes
book/docs/setup/MacOS.md Outdated
Comment on lines 52 to 54
9 - Try building the Plutus PAB (This may take some time :) be patient)

9 - Build the Plutus Core (This may take some time :) be patient)

[$] nix build -f default.nix plutus.haskell.packages.plutus-core.components.library

[$] nix build -f default.nix plutus-apps.haskell.packages.plutus-pab.components.library
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary.

book/docs/setup/MacOS.md
@@ -182,7 +180,7 @@ Segmentation fault: 11
```

Copy link

@nrkramer nrkramer Jan 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running either the server or client will require GC_DONT_GC=1 be prepended to the command.

This is because the garbage collector incorrectly marks some of the dependencies as unneeded. See https://github.com/renzwo/cardano-plutus-apps-install-m1/blob/main/README.md. These instructions work well for both M1 and Intel-based Macs.

Sadly it's not yet possible to run plutus-playground without support from Rosetta 2. Hopefully, once IOHK has all the ARM binary caches ready, it will be possible.

@bjing
Copy link
Contributor Author

bjing commented Jan 20, 2022

I've updated whatever I can. Let me know if there's still issues.

@bjing bjing changed the title Update instructions on macOS Fix plutus-apps repo location Jan 20, 2022
@nstankov-bg
Copy link
Owner

Thank you!!!

@nstankov-bg nstankov-bg merged commit e5c0c61 into nstankov-bg:main Jan 21, 2022
@bjing bjing deleted the update-macos-setup branch January 23, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrkramer nrkramer nrkramer requested changes

@nstankov-bg nstankov-bg Awaiting requested review from nstankov-bg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjing @joaquimgamero @nstankov-bg @nrkramer