coverage.sh: adds Code Coverage generation #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does the output look like? |
|
The default output: |
|
Sample HTML (screencap) |
|
@kenjones-cisco is there a summary output? |
|
@mreiferson Since the coverage is actually generated on a per package level to start with then you would see a summary for each package printed to stdout. Very similar to what you see now when it shows the results of the tests, how long it took, but using this it would include coverage summary for the package. fictional example: |
|
@kenjones-cisco feel like we should just integrate the repo with coveralls.io so we get continuous reporting? |
|
@mreiferson I like that idea as well, I actually took that option out of the script as that required you guys to setup up that integration. But the same script could handle pushing the data into coveralls as well. The output from the script as it is, helps developers see the coverage or lack there of then making changes. I'm a huge fan over tracking coverage of all projects 👍 |
|
I can setup the integration and add the |
|
I'll update the script accordingly. |
|
Cool, thanks, the environment variable should be ready to go. |
kenjones-cisco
force-pushed
the
test/add-coverage
branch
from
eb704fa to
431bb62
Compare
|
Changes Unknown when pulling 431bb62 on kenjones-cisco:test/add-coverage into * on nsqio:master*. |
|
@mreiferson Changes made and the results made it over to coveralls; seem to be hitting the DiskQueue intermittent test case failures. But otherwise it worked well. |
|
Need to turn off that comment thing 👊 |
|
this is great, want to add the badge to the README while we're in here? |
|
|
@kenjones-cisco can we skip |
|
I'll add the badge and because each file gets coverage generated, we could definitely add an exception for bindata. |
kenjones-cisco
force-pushed
the
test/add-coverage
branch
from
431bb62 to
acfef9b
Compare
|
@kenjones-cisco this ready to land? |
Adds script for generating code coverage statistics for Go packages. Borrowed from https://github.com/hashicorp/vault
kenjones-cisco
force-pushed
the
test/add-coverage
branch
from
acfef9b to
b3b71ed
Compare
|
The ignore didn't work, trying another pattern for ignore, such that bindata does not show up. Since goveralls supports an ignore files, I'm hoping it is that simple and it is just a case of getting the proper pattern. |
|
@mreiferson Now it is ready! |
|
this is great 💯 |
|
@mreiferson seems the URL for the badge was incomplete, should have been Not sure if you want to make the minor update or if you need another PR. |
|
I'll fix, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds script for generating code coverage statistics for Go packages.
Borrowed from https://github.com/hashicorp/vault