nsqd: add msg header size to diskqueue MaxMsgSize #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- purpose: diskqueue was enforcing a maxmsgsize of the whole message including header, while protocol enforces maxmsgsize on the body. this could lead to successful writes to the memory queue but failed writes to the diskqueue, intermittently if the body size was within the 26 bytes range. - channel / topic tests assert configuration is passed correctly to diskqueue; it doesn't test PutMessage directly because enforcing msg size is the responsibility of protocol. - add maxMsgSize to diskqueue writeOne error message.
|
LGTM |
mreiferson
changed the title
mreiferson
added a commit
that referenced
this pull request
Oct 15, 2015
nsqd: add msg header size to diskqueue MaxMsgSize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including header, while protocol enforces maxmsgsize on the body. this
could lead to successful writes to the memory queue but failed writes
to the diskqueue, intermittently if the body size was within the
26 bytes range.
diskqueue; it doesn't test PutMessage directly because enforcing msg
size is the responsibility of protocol.