nsqadmin: conf flags for formatting statsd counters and gauges #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,6 @@ Read the [docs](http://nsq.io/components/nsqadmin.html) | |||
| 3. `$ gulp clean watch` or `$ gulp clean build` | |||
| 4. `$ go-bindata --debug --pkg=nsqadmin --prefix=static/build static/build/...` | |||
| 5. `$ cd ../nsqadmin && go build && ./nsqadmin` | |||
| 6. make changes | |||
| 6. make changes (and repeat steps 4 and 5 to see changes) | |||
There was a problem hiding this comment.
This isn't always true (specifically, it's only true when you're making changes to the Go code of nsqadmin). Another way of communicating this is to say (repeat step 5 if you make changes to any Go code)
|
@jehiah what do you think? |
|
also, thanks for putting this together @kesutton! |
| @@ -53,16 +72,19 @@ var genColorList = function(typ, key) { | |||
|
|
|||
| var genTargets = function(typ, node, ns1, ns2, key) { | |||
| var targets = []; | |||
| var prefix = statsdPrefix(node ? node : '*', metricType(key)); | |||
| var nsqPrefix = nsqStatsdPrefix(node ? node : '*'); | |||
There was a problem hiding this comment.
style nitpick, can we drop the nsq on these variable/function names?
|
I think this LGTM other than the minor comment, thanks! |
mreiferson
changed the title
|
I will fix the comment. Did you guys come to a decision about the avlue of keeping legacy functionality that was already broken? |
|
I'm OK with it. |
|
Want to rebase/squash? |
|
squashed and rebased on latest |
|
thanks |
mreiferson
added a commit
that referenced
this pull request
Oct 5, 2015
nsqadmin: conf flags for formatting statsd counters and gauges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#661
I want to reiterate that because there was a bug where the "use-statsd-prefixes" flag was not actually passed to nsqadmin, and thus useless, now would be the best time to eliminate that flag. Unless it worked in the past, in which case I understand backwards compatibility.