nsqadmin: disambiguate nsqadmin notifications #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jehiah
force-pushed
the
nsqadmin_notify_653
branch
from
c3f0fc2 to
e52c6d1
Compare
jehiah
force-pushed
the
nsqadmin_notify_653
branch
from
e52c6d1 to
215ab9f
Compare
|
RFR @mreiferson I get the following json output now (and will update docs after this lands ) {
"via": "jehiah.local",
"url": "http://jehiah.local:4171/api/topics/api_requests/nsq_to_file",
"user_agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.99 Safari/537.36",
"remote_ip": "10.0.1.7:55983",
"timestamp": 1442931083,
"channel": "nsq_to_file",
"topic": "api_requests",
"action": "unpause_channel"
} |
|
LGTM |
mreiferson
added a commit
that referenced
this pull request
Sep 22, 2015
nsqadmin: disambiguate nsqadmin notifications
|
Docs updated in nsqio/nsqio.github.io@fe67beb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the hostname that nsqadmin is access through, and the host running nsqadmin to the context of nsqadmin notifications. This is particularly useful if you have the same topics and channels in more than one cluster (say different datacenters) and you want to be able to disambiguate between the two.