Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqadmin: dedupe of producers from lookupd not working #650

Merged
merged 1 commit into from
Sep 19, 2015

Conversation

mreiferson
Copy link
Member

Something in the change of GetLookupdProducers from #421 broke the de-duping of hosts in nsqadmin when configured to query multiple nsqlookupds.

screen shot 2015-09-18 at 11 37 48 am

cc: @mreiferson

@jehiah jehiah added the bug label Sep 18, 2015
@mreiferson
Copy link
Member

I think it was this commit: mreiferson@acb4427#diff-b6cc96c8e9cf50b076b921c9089d220cL224

Fixing...

@mreiferson mreiferson added this to the nsqadmin refactoring milestone Sep 18, 2015
@mreiferson
Copy link
Member

RFR @jehiah

jehiah added a commit that referenced this pull request Sep 19, 2015
nsqadmin: dedupe of producers from lookupd not working
@jehiah jehiah merged commit 5b476e9 into nsqio:master Sep 19, 2015
@mreiferson mreiferson deleted the nsqadmin_producer_dedupe_650 branch September 19, 2015 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants