Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the great deprecation purge #367

Merged
merged 6 commits into from
Dec 29, 2016
Merged

the great deprecation purge #367

merged 6 commits into from
Dec 29, 2016

Conversation

mreiferson
Copy link
Member

a WIP list of things that are currently deprecated that will be purged in 1.0

  • old response format HTTP endpoints
  • BroadcastAddress / Address dance
  • --max-message-size flag in nsqd
  • --verbose flag in bundled apps
  • --gzip-compression flag in nsq_to_file
  • --round-robin flag in nsq_to_http
  • --max-backoff-duration flag in nsq_to_http and nsq_to_nsq
  • --throttle-fraction flag in nsq_to_http
  • --http-timeout-ms flag in nsq_to_http
  • long_id and short_id attributes in IDENTIFY
  • name attribute in /stats response in nsqd
  • --template-dir flag in nsqadmin

@mreiferson mreiferson added the 1.0 label Jun 4, 2014
@mreiferson mreiferson mentioned this pull request Jun 20, 2014
Merged
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch 2 times, most recently from 121c9cd to 925b0a0 Compare August 11, 2015 15:33
@mreiferson mreiferson mentioned this pull request Aug 16, 2015
Closed
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch 4 times, most recently from 98d6ea2 to 0cc169e Compare August 29, 2015 16:09
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch from 0cc169e to f04cd50 Compare September 5, 2015 17:38
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch 3 times, most recently from 0a5b376 to e658ecb Compare September 17, 2015 03:34
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch from 07c76c5 to 1d39edf Compare September 20, 2015 14:49
@mreiferson mreiferson mentioned this pull request Sep 21, 2015
Merged
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch from 1d39edf to acab679 Compare September 25, 2015 16:04
@mreiferson
Copy link
Member Author

we doing this @jehiah ?

@jehiah
Copy link
Member

jehiah commented Sep 26, 2015

we just need to bump the internal/version in master first to 1.0-alpha ?

@mreiferson mreiferson mentioned this pull request Sep 29, 2015
Closed
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch 2 times, most recently from bcd1fbb to 1eb28ad Compare October 4, 2015 21:30
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch from 1eb28ad to f21fd5c Compare October 18, 2015 16:43
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch from 942eb25 to b7689df Compare December 19, 2015 16:21
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch 2 times, most recently from ca66260 to c872bb4 Compare April 18, 2016 15:17
@mreiferson
Copy link
Member Author

🔥 let's land this?!?!?!?

We don't have to figure out version numbers in this PR.

@mreiferson mreiferson force-pushed the deprecation_purge_367 branch from c872bb4 to a9f8095 Compare July 15, 2016 20:22
@mreiferson mreiferson mentioned this pull request Aug 2, 2016
Merged
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch 2 times, most recently from f6e02c8 to f2fe3bc Compare August 16, 2016 21:13
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch from f2fe3bc to f05534a Compare August 16, 2016 21:39
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch from f05534a to 5409a25 Compare December 28, 2016 23:02
@mreiferson mreiferson force-pushed the deprecation_purge_367 branch from 5409a25 to 91e0e18 Compare December 28, 2016 23:03
@mreiferson mreiferson merged commit c7623b5 into nsqio:master Dec 29, 2016
@mreiferson mreiferson deleted the deprecation_purge_367 branch December 29, 2016 06:02
@mreiferson mreiferson mentioned this pull request Jan 2, 2017
Merged
This was referenced Feb 17, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jehiah jehiah jehiah approved these changes

Assignees
No one assigned
Labels
1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mreiferson @jehiah