Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add go-1.17 to test matrix, remove go-1.13 #1373

Merged
merged 2 commits into from
Sep 6, 2021
Merged

CI: add go-1.17 to test matrix, remove go-1.13 #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29114b3
CI: add go-1.17 to test matrix, remove go-1.13
ploxiln Sep 5, 2021
dc60cfd
nsq_to_file: Signal channels should be buffered
ploxiln Sep 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ jobs:
fail-fast: false
matrix:
imgtag:
- "golang:1.13-buster"
- "golang:1.14-buster"
- "golang:1.15-buster"
- "golang:1.16-buster"
- "golang:1.16-bullseye"
- "golang:1.17-bullseye"
goarch:
- "amd64"
- "386"
Expand Down Expand Up @@ -44,7 +44,7 @@ jobs:
send-coverage:
runs-on: ubuntu-20.04
timeout-minutes: 30
container: "golang:1.16-buster"
container: "golang:1.16-bullseye"
env:
GOPATH: "${{github.workspace}}/go"
SRCDIR: "go/src/github.com/nsqio/nsq"
Expand All @@ -55,7 +55,7 @@ jobs:
path: ${{env.SRCDIR}}

- name: Install goveralls
run: GO111MODULE=off go get github.com/mattn/goveralls
run: go install github.com/mattn/goveralls@latest

- name: Send coverage
env:
Expand Down
4 changes: 2 additions & 2 deletions apps/nsq_to_file/nsq_to_file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@ func main() {
cfg.UserAgent = fmt.Sprintf("nsq_to_file/%s go-nsq/%s", version.Binary, nsq.VERSION)
cfg.MaxInFlight = opts.MaxInFlight

hupChan := make(chan os.Signal)
termChan := make(chan os.Signal)
hupChan := make(chan os.Signal, 1)
termChan := make(chan os.Signal, 1)
signal.Notify(hupChan, syscall.SIGHUP)
signal.Notify(termChan, syscall.SIGINT, syscall.SIGTERM)

Expand Down