Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: test script failing to run -race #1333

Merged
merged 1 commit into from
Mar 28, 2021
Merged

*: test script failing to run -race #1333

merged 1 commit into from
Mar 28, 2021

Conversation

mreiferson
Copy link
Member 

./test.sh: 6: [: amd64: unexpected operator
./test.sh: 6: [: arm64: unexpected operator

See this in every test run, which means we're never running with -race

cc @ploxiln

@mreiferson mreiferson requested a review from ploxiln March 28, 2021 18:39
ploxiln
ploxiln approved these changes Mar 28, 2021
View reviewed changes
Copy link
Member

@ploxiln ploxiln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes, == is a bashism, posix sh specifies only = in this context, and /bin/sh on debian/ubuntu is dash (minimal posix shell) rather than bash

@mreiferson mreiferson merged commit 798b939 into nsqio:master Mar 28, 2021
@mreiferson mreiferson deleted the test-script branch March 28, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ploxiln ploxiln ploxiln approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mreiferson @ploxiln