Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqd: diskqueue ReadChan now receive-only chan #1209

Merged
merged 1 commit into from
Dec 14, 2019
Merged

nsqd: diskqueue ReadChan now receive-only chan #1209

merged 1 commit into from
Dec 14, 2019

Conversation

bitpeng
Copy link
Contributor

@bitpeng bitpeng commented Nov 2, 2019 •
edited by ploxiln
Loading

ReadChan return receive-only chan for reading, I also open a pr for nsqio/go-diskqueue#7

@bitpeng
Copy link
Contributor Author

bitpeng commented Nov 5, 2019

@ploxiln @mreiferson

@bitpeng bitpeng mentioned this pull request Dec 10, 2019
Closed
@ploxiln
Copy link
Member

ploxiln commented Dec 13, 2019

please update Gopkg.toml, and run dep to update Gopkg.lock, so that non-module builds of nsq still work (and that will also fix the tests)

@bitpeng
Copy link
Contributor Author

bitpeng commented Dec 13, 2019

please update Gopkg.toml, and run dep to update Gopkg.lock, so that non-module builds of nsq still work (and that will also fix the tests)

@ploxiln done, please review the code. thanks

@ploxiln
Copy link
Member

ploxiln commented Dec 13, 2019

Looks good. Can you please squash the commits down to one? (We like to have both a merge commit, and cleaned-up git history.) Thanks :)

@bitpeng bitpeng force-pushed the ReadChan_should_return_receiveOnly_chan branch from 7e78e28 to e883f9b Compare December 14, 2019 11:43
@bitpeng
Copy link
Contributor Author

bitpeng commented Dec 14, 2019

@ploxiln Sorry, I am not really familiar with Git. Is that ok? thanks

@ploxiln ploxiln changed the title update: ReadChan return receive-only chan for reading diskqueue ReadChan now receive-only chan Dec 14, 2019
@ploxiln
Copy link
Member

ploxiln commented Dec 14, 2019

yup, that worked

@ploxiln ploxiln merged commit f6bc2bf into nsqio:master Dec 14, 2019
@mreiferson mreiferson changed the title diskqueue ReadChan now receive-only chan nsqd: diskqueue ReadChan now receive-only chan Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitpeng @ploxiln @mreiferson