Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqd: ephemeral channel race condition with reconnecting client #883

Closed
mreiferson opened this issue Apr 15, 2017 · 2 comments
Closed

nsqd: ephemeral channel race condition with reconnecting client #883

mreiferson opened this issue Apr 15, 2017 · 2 comments
Labels
bug

Comments

@mreiferson
Copy link
Member

It's possible for a client reconnecting quickly and subscribed to an ephemeral channel to race with nsqd's cleanup of said ephemeral channel, as documented in nsqio/go-nsq#206.
@mreiferson mreiferson added the bug label Apr 15, 2017
@mreiferson mreiferson mentioned this issue Apr 15, 2017
Closed
slayercat added a commit to slayercat/nsq that referenced this issue Apr 17, 2017
@slayercat
when topic destroying. make nsqd won't assign any new client into it
4c42cab 
fix nsqio#883
@slayercat slayercat mentioned this issue Apr 17, 2017
Closed
@slayercat
Copy link

I send a commit, makes DeleteExistingTopic hold a nsq global lock. so, new connection shell wait for delete operation done.

The commit seems fix this issue.

I'm thinking if it make sense to remove topic from n.topicMap before delete it, so new topic can be created, when the old topic been deleted.

@mreiferson
Copy link
Member Author

see #886

slayercat added a commit to slayercat/nsq that referenced this issue Apr 18, 2017
@slayercat
When topic destroying. make nsqd won't set any new clients into that.
b3d3769 
fix nsqio#883
slayercat pushed a commit to slayercat/nsq that referenced this issue May 2, 2017
nsqd: SUB: fix ephemeral channel race condition with reconnecting cli…
0eb302c 
…ent.

It's possible for a client reconnecting quickly and subscribed to an ephemeral channel to race with nsqd's cleanup of said ephemeral channel, as documented in nsqio/go-nsq#206.

Fixes nsqio#883
slayercat pushed a commit to slayercat/nsq that referenced this issue May 2, 2017
nsqd: SUB: fix ephemeral channel race condition with reconnecting cli…
5bcb654 
…ent.

It's possible for a client reconnecting quickly and subscribed to an ephemeral channel to race with nsqd's cleanup of said ephemeral channel, as documented in nsqio/go-nsq#206.

Fixes nsqio#883
slayercat pushed a commit to slayercat/nsq that referenced this issue May 2, 2017
nsqd: SUB: fix ephemeral channel race condition with reconnecting cli…
bcd6938 
…ent.

It's possible for a client reconnecting quickly and subscribed to an ephemeral channel to race with nsqd's cleanup of said ephemeral channel, as documented in nsqio/go-nsq#206.

Fixes nsqio#883
@ploxiln ploxiln mentioned this issue May 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mreiferson @slayercat